Bump swift-syntax upper bound to allow 603.x#401
Open
BenjaminPrieur wants to merge 1 commit into
Open
Conversation
The dependency was capped at "510.0.3"..<"603.0.0", resolving to a max of 602.x. This forces consumers that also depend on swift-syntax down to 602.x, even on Swift 6.3 toolchains. Raise the upper bound to 604.0.0 so 603.x (the Swift 6.3-matching release) is allowed. Builds clean and all 14 tests pass against swift-syntax 603.0.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Swift package caps
swift-syntaxat"510.0.3" ..< "603.0.0"(Package.swift), which resolves to a maximum of 602.x.SwiftPM resolves every dependency to a single version that satisfies the intersection of all constraints in the dependency graph. So when a project depends on both Code Connect and
swift-syntaxdirectly (or via another package), Code Connect's< 603.0.0ceiling forces the entire graph down to 602.x — even on a Swift 6.3 toolchain, whose matchingswift-syntaxrelease is 603.x. In practice this silently downgrades swift-syntax in the consuming project, which can break code that relies on 603-only API or simply causes an unwanted version regression.swift-syntaxfollows the toolchain: 600 → Swift 6.0, 601 → 6.1, … 603 → 6.3. There's no reason for Code Connect to exclude the release that matches the current toolchain.What
Raise the upper bound to
604.0.0so 603.x is allowed:The wide lower bound is kept, so older toolchains stay supported — this only stops capping below 603.
Verification
Built and tested against the newly-resolved
swift-syntax603.0.1 on Swift 6.3.2:swift build— clean (only two pre-existingis/ascast deprecation warnings, unrelated to this change)swift test— 14/14 tests pass (CodeConnectParserTest,CodeConnectTemplateWriterTest,CodeConnectUploaderTest)