Conversation
|
|
0x5bfa
force-pushed
the
mdta-new-properties-dialog
branch
from
August 21, 2026 02:29
d1cec6d to
fda1afb
Compare
Created a new branch and put an initial bit of xaml together as a starting point
Starting with the Toggle Button style that is used for the Expander control's header
Finished making the custom styles for the Up and Down versions of the PropertiesExpander Header ToggleButtons Up is based on Down, but only the On and Off glyphs are swapped. Tested with enabled and disabled, as well as High Contrast brushes
I have started exploring integrating the ToggleButton styles for the Header buttons into the Expander control, and trying to figure out how to handle overrides of things like BorderThickness and Border/Background colours.
I have the new Header style and design in place and working, I would like @Tera to give it a look over, to see if I have overlooked anything of course
To be used in the Expander Header to give correct alignment of IconElement and Text to enable wrapping and correct alignment for long headers
There is an Orientation property Label and Text string properties and a LabelWidth GridLength property to ensure alignments can match There is also a CanEdit bool which swaps out a TextBlock for a TextBox control
With a new PropertiesViewItem as a control, with other controls derived from it, we can share code and avoid duplicating Dependency Properties. Started work on a Ratings variation of the control
Also tweaked font weights for headers, and indentation for items within the expanders
… more info Am happy to change the icon or styling of the Info icon, or to also discuss ways to maybe make the tooltip element more flexible. Content rather than InfoText string as a property perhaps?
0x5bfa
force-pushed
the
mdta-new-properties-dialog
branch
from
August 21, 2026 02:29
fda1afb to
f3d2eb0
Compare
Awaiting verification of functionality from @Tera
It is a simple control that can be Horizontal or Vertical - making it flexible to use across the Properties View pages. I may be able to simplify by switching to a single border, and manually changing the properties to change it's shape - but for now its a simple Visible and Collapse visual state
Derived from CheckBox and reusing most of the default template, enables the whole item to be clickable, not just the check box - with an added Orientation property to enable stacked layout
…an't make the template align how I want.
…y the styling Lots of trial and error work, pushing so the working state will be preserved to git history
Pushing my work so far, as I think I have made some good progress - still more to do and tidy up, and there are some issues like the control not having awareness of missing headers, and how to re-flow in those circumstances.
…ough As @Tera implements more of the Dialog pages, we will come across tweaks needed, that I may need help to solve. At the moment we will need to adjust margins on text boxes, when in vertical cards - not sure if thats at the dialog level or something we need to do in the control.
I have added DependencyProperties to set the alignment via static resources, which allows us to override them in XAML so when placing a TextBox (or other control that needs it) in a PropertiesViewCard - we can have it behave differently when hitting the Left, Right and Wrapped breakpoints (Vertical uses wrapped) The idea came to me when I was attempting to sleep...
yair100
force-pushed
the
main
branch
7 times, most recently
from
September 7, 2026 22:51
0b848cc to
3a7c7ed
Compare
|
@mdtauk, I have a question, will this replace the one accessed on the desktop via properties on right click from the desktop default context menu as well, or no, if not, I hope it's considered to do this, because I do want to have a consistent experience when I use the desktop compared to just the file manager. |
Contributor
Author
I don't think there is any mechanism within Windows for bypassing the standard Explorer.exe properties dialog. As it stands, this is for when using the Files app. |
|
well here's a program that has done that to parts of the shell (not neccessarily properties, but it may give us the blueprint for properties): https://github.com/IviriusCommunity/Rebound, I recommend taking a look at it |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial branch for Myself @mdtauk and @0x5bfa to put together a prototype for updating the designs of the Properties Dialog and hopefully improving the implementation of some API access at the same time.
DO NOT MERGE OR TAKE ACTION ON WHILST IT IS STILL IN DRAFT FORM
Images are illustrative based on the design ideation from Figma, final design may change during development