Skip to content

[SPIKE] Event oneOf discriminated union (INTER-2457) - #49

Open
JuroUhlar wants to merge 1 commit into
mainfrom
spike/INTER-2457-event-oneof
Open

[SPIKE] Event oneOf discriminated union (INTER-2457)#49
JuroUhlar wants to merge 1 commit into
mainfrom
spike/INTER-2457-event-oneof

Conversation

@JuroUhlar

Copy link
Copy Markdown
Contributor
  • Regenerated from the INTER-2457 Event oneOf (EventDevice | EventEdge, discriminator source).
  • Added SPIKE comments at the compile break sites. Do not merge.

Break: compile / binary

Event used to be a class with getIdentification(). It is now an interface (useOneOfInterfaces: true) with no getIdentification(). api.getEvent(id).getIdentification() does not compile. Identification is on EventDevice.

Known issue: CI will fail

The SDK and tests are expected not to compile. That is the spike.

INTER-2457. Regenerated Event as an interface to show the compile break. Do not merge.
@github-actions

Copy link
Copy Markdown
Contributor

Wrong commit message format detected

We use Semantic Commit Messages in our project.

Warning
Probably you forgot to activate local git hooks.

Run the next command in the project root to activate local hooks:

sh ./install_hooks.sh

More info you can find in job logs

Commitlint Errors

Commit: 9cf2407 `chore: SPIKE Event oneOf discriminated union

INTER-2457. Regenerated Event as an interface to show the compile break. Do not merge.`
Errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Template files and generated files are not in-sync.

Following files do not match corresponding templates:
sdk/src/main/java/com/fingerprint/v4/api/FingerprintApi.java sdk/src/main/java/com/fingerprint/v4/model/Event.java

To fix this warning, make sure template files are up-to-date, and generate files by running the following command:

bash ./scripts/generate.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant