Description
[REQUIRED] Please fill in the following fields:
- Pre-built SDK from the website
- Firebase C++ SDK version: 11.9.0
- Problematic Firebase Component: Storage
- Other Firebase Components in use: Auth, App, Analytics, Remote Config, Dynamic Links
- Platform you are using the C++ SDK on: Mac
- Platform you are targeting: iOS
[REQUIRED] Please describe the issue here:
The argument path of StorageReferenceInternal::GetFile is not copied and passed verbatim as a pointer to another thread in:
download_task = [my_impl writeToFile:[NSURL URLWithString:@(path)] completion:completion];
This would not work if path was passed from a C++ temporary and the expectation that the caller must ensure the lifetime of path supersedes the download time is unrealistic. Most developers would expect path to be copied if you need to carry it to another thread.
Stack trace during EXC_BREAKPOINT (code=1, subcode=0x1bc5fa4b0) as it processes garbage after temporary:
#0 0x00000001bc5fa4b0 in static URL._unconditionallyBridgeFromObjectiveC(_:) ()
#1 0x00000001064caf5c in @objc StorageReference.write(toFile:completion:) ()
#2 0x0000000101c6622c in invocation function for block in firebase::storage::internal::StorageReferenceInternal::GetFile(char const*, firebase::storage::Listener*, firebase::storage::Controller*) at /Users/me/Projects/firebase-cpp-sdk/storage/src/ios/storage_reference_ios.mm:149
#3 0x00000001067ac08c in _dispatch_call_block_and_release ()
#4 0x00000001067ad8c4 in _dispatch_client_callout ()
#5 0x00000001067bc428 in _dispatch_main_queue_drain ()
#6 0x00000001067bc080 in _dispatch_main_queue_callback_4CF ()
#7 0x00000001c2013828 in __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ ()
#8 0x00000001c1ff74a8 in __CFRunLoopRun ()
#9 0x00000001c1ffbb58 in CFRunLoopRunSpecific ()
#10 0x00000001f81fb984 in GSEventRunModal ()
#11 0x00000001c43a6628 in -[UIApplication _run] ()
#12 0x00000001c43a62a0 in UIApplicationMain ()
#13 0x0000000100ea697c in main at /Users/me/path/to/main.m:24
#14 0x00000001decc5df0 in start ()
Enqueued from com.apple.NSXPCConnection.m-user.com.apple.ondemandd.client (Thread 5) Queue : com.apple.NSXPCConnection.m-user.com.apple.ondemandd.client (serial)
#0 0x00000001067b1dc0 in dispatch_async ()
#1 0x0000000101cb8708 in firebase::util::DispatchAsyncSafeMainQueue(void () block_pointer) ()
#2 0x0000000101c65c58 in firebase::storage::internal::StorageReferenceInternal::GetFile(char const*, firebase::storage::Listener*, firebase::storage::Controller*) at /Users/me/Projects/firebase-cpp-sdk/storage/src/ios/storage_reference_ios.mm:145
#3 0x0000000101c5af6c in firebase::storage::StorageReference::GetFile(char const*, firebase::storage::Listener*, firebase::storage::Controller*) at /Users/me/Projects/firebase-cpp-sdk/storage/src/common/storage_reference.cc:150
#4 0x0000000100b35fa0 in start_download(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&,std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&) at my/path/myfile.cpp:3967
Steps to reproduce:
No. Your Firebase C++ quickstarts is useless in reproducing real-world issues as it busy-waits after each call, hiding all the multi-threading issues you guys have. This is just one of them, more to follow. Rewrite it to include multi-threading scenarios.
What's the issue repro rate? 100%
Just use the following function to reproduce the problem:
Relevant Code:
void start_download(const std::string& local_path, const std::string& remote_path)
{
firebase::storage::StorageReference path_reference = firebase::storage::Storage::GetInstance(::firebase::App::GetInstance())->GetReference(remote_path);
path_reference.GetFile(("file://" + local_path).c_str(), listener.get(), &listener->m_controller); // Temporary ("file://" + local_path) is destroyed after ;
}