fix(api/crawler/sitemap): bump sitemap limit#2079
Merged
Conversation
![cubic-dev-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (this.sitemapsHit.size >= 20) { | ||
| if (this.sitemapsHit.size >= 100) { |
Contributor
There was a problem hiding this comment.
Replace the magic number 100 with a shared constant to keep the sitemap limit consistent across modules and avoid future drift.
Prompt for AI agents
Address the following comment on apps/api/src/scraper/WebScraper/crawler.ts at line 867:
<comment>Replace the magic number 100 with a shared constant to keep the sitemap limit consistent across modules and avoid future drift.</comment>
<file context>
@@ -864,7 +864,7 @@ export class WebCrawler {
}
- if (this.sitemapsHit.size >= 20) {
+ if (this.sitemapsHit.size >= 100) {
this.logger.warn("Sitemap limit hit!", { crawlId: this.jobId, url: this.baseUrl });
}
</file context>
mogery
commented
Sep 1, 2025
Member
Author
mogery
left a comment
mogery
left a comment
There was a problem hiding this comment.
@cubic-dev-ai review pls
Member
Author
|
@cubic-dev-ai review pls |
Contributor
@mogery I've started the AI code review. It'll take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Increase sitemap processing limit from 20 to 100 to improve crawl coverage on larger sites and avoid early cutoffs. Updates limit checks in crawler.ts and sitemap.ts to align with ENG-3309’s need for bigger sitemap support.