Question concerning TembedWifiSetup.cpp and the way it interacts with the user

[fdufnews]

Hi,
I am currently trying to add the Lyligo T-display hardware to the list of supported hardware.

T-display is not very different from T-Embed hardware. Apart from the display's interface, the main difference is that instead of a rotary encoder, T-Display has only 2 buttons.

I have written TdisplayDeviceView and TdisplayInput modules and I am now looking at writing a TdisplayWifiSetup (or maybe reusing TembedWifiSetup). I am currently using as a base the TembedWifiSetup and I am really surprised that TembedWifiSetup contains a large part of the TembedInput module.

So I am asking myself, why is TembedWifiSetup duplicating the code from TembedInput and not using deviceInput to get input from the user?
I'm not always comfortable with object-oriented programming, maybe I have missed something.
Regards

[geo-tp]

The WiFi setup codes for devices are not directly integrated into the architecture, most of these setups come from other projects and were simply copied and pasted without any integration work with the existing codebase, making them very easily reusable, but having the drawback of not directly using the classes designed for this purpose

The best solution would be to properly integrate all these setups into the existing architecture, which requires a lot of work, so creating a separate standalone setup in /Vendors for your new device might suffice

[fdufnews]

Ok, I understand the reason.
Thanks for the quick answer.