build: Actually use import eslint rules #16134
Open
+1,656
−2,489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Apr 25, 2025
mydea
added a commit
that referenced
this pull request
Apr 25, 2025
…16135) Extracted out of #16134 During that refactor, a bunch of stuff failed. The reason for this is that we relied on a side-effect mock in `use-fake-timers` utility, which is really not ideal at all. So this refactors this to instead make this explicit, as a side-effect import on the top of the test files. Then we can just use `vi.useFakeTimers()` normally.
all the remaining changes
mydea
force-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.