fix(user): Set user.ip_address on telemetry if present - #6555
Merged
Conversation
Contributor
Codecov Results 📊✅ 89401 passed | ⏭️ 6013 skipped | Total: 95414 | Pass Rate: 93.7% | Execution Time: 298m 12s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2398 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.81% 89.78% -0.03%
==========================================
Files 192 192 —
Lines 23457 23457 —
Branches 8060 8060 —
==========================================
+ Hits 21066 21059 -7
- Misses 2391 2398 +7
- Partials 1329 1328 -1Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Jun 11, 2026
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
) ### Description If user data is set on scope, we should materialize it onto attributes-based telemetry (metrics, logs, spans v2) at the end. The code for that was there and working, but we were omitting `ip_address`. #### Issues <!-- * resolves: getsentry#1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If user data is set on scope, we should materialize it onto attributes-based telemetry (metrics, logs, spans v2) at the end. The code for that was there and working, but we were omitting
ip_address.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)