Skip to content

ci: Remove pytest-localserver from requirements-testing.txt - #6612

Merged
alexander-alderman-webb merged 11 commits into
masterfrom
webb/requirements-testing/pytest-localserver
Jun 24, 2026
Merged

ci: Remove pytest-localserver from requirements-testing.txt#6612
alexander-alderman-webb merged 11 commits into
masterfrom
webb/requirements-testing/pytest-localserver

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the package from requirements-testing.txt and add the package as a dependency to only the test suites that rely on the package (if applicable).

This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.

Issues

Reminders

Comment thread requirements-testing.txt
Comment thread tests/conftest.py Outdated
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

89835 passed | ⏭️ 6136 skipped | Total: 95971 | Pass Rate: 93.61% | Execution Time: 317m 40s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -1566
Passed Tests 📉 -1566
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2403 uncovered lines.
❌ Project coverage is 89.89%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.90%    89.89%    -0.01%
==========================================
  Files          192       192         —
  Lines        23763     23763         —
  Branches      8206      8206         —
==========================================
+ Hits         21362     21360        -2
- Misses        2401      2403        +2
- Partials      1344      1346        +2

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title ci: Remove pytest-localserver from requirements-testing.txt Jun 23, 2026
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review June 23, 2026 09:20
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner June 23, 2026 09:20

@ericapisani ericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-alderman-webb
alexander-alderman-webb merged commit 5e2c658 into master Jun 24, 2026
270 of 272 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/requirements-testing/pytest-localserver branch June 24, 2026 07:53
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
…entry#6612)

Remove the package from `requirements-testing.txt` and add it only as a dependency of the test suites that rely on it. Add a dependency on `werkzeug`, which was transitively pulled in by `pytest-localserver`.
Add `dataclasses` as a dependency for `sanic` tests on Python 3.6, to avoid an unhandled `ImportError` that arose after moving the `pytest-localserver` dependency.
This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants