Skip to content

ci: Remove jsonschema from requirements-testing.txt - #6620

Merged
alexander-alderman-webb merged 4 commits into
masterfrom
webb/requirements-testing/jsonschema
Jun 23, 2026
Merged

ci: Remove jsonschema from requirements-testing.txt#6620
alexander-alderman-webb merged 4 commits into
masterfrom
webb/requirements-testing/jsonschema

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the package from requirements-testing.txt and add the package as a dependency to only the test suites that rely on the package (if applicable).

This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.

Issues

Reminders

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

91388 passed | ⏭️ 6136 skipped | Total: 97524 | Pass Rate: 93.71% | Execution Time: 334m 21s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2410 uncovered lines.
✅ Project coverage is 89.86%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.86%    89.86%        —%
==========================================
  Files          192       192         —
  Lines        23758     23758         —
  Branches      8204      8204         —
==========================================
+ Hits         21349     21348        -1
- Misses        2409      2410        +1
- Partials      1344      1344         —

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review June 23, 2026 09:18
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner June 23, 2026 09:18

@ericapisani ericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-alderman-webb
alexander-alderman-webb merged commit de01d8b into master Jun 23, 2026
139 of 144 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/requirements-testing/jsonschema branch June 23, 2026 14:40
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Remove the package from `requirements-testing.txt` and add it only as a dependency of the test suites that rely on it.
This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants