fix(pyreqwest): Gate url.full, url.query, url.fragment on send_default_pii

[ericapisani]

Summary

• Gate url.full, url.query, and url.fragment span attributes behind should_send_default_pii() in the streamed span path
• Update tests to parametrize on send_default_pii and assert attributes are present/absent accordingly

Fixes PY-2560
Fixes #6671

[linear-code]

PY-2560

[sentry-warden]

Non-streaming test assertions always expect URL/query/fragment, regardless of send_default_pii

In test_sync_client_spans, the non-streaming else branch unconditionally asserts span['data']['url'], HTTP_QUERY, and HTTP_FRAGMENT are present even when send_default_pii=False, so the test suite will not catch PII leaking through the non-streaming path.

Evidence

• test_sync_client_spans is parametrized with send_default_pii in [True, False].
• The streaming if span_streaming: branch gates assertions with if send_default_pii: ... else: assert 'url.full' not in ....
• The non-streaming else: branch has no such conditional: it always asserts span['data']['url'] == ..., span['data'][SPANDATA.HTTP_QUERY] == 'q=test', and span['data'][SPANDATA.HTTP_FRAGMENT] == 'frag' for both PII settings.
• This means the send_default_pii=False parametrized case passes even though PII is being leaked, giving false confidence.

_{Identified by Warden code-review}

[sentry]

Bug: The non-streamed request path in the pyreqwest integration does not respect the should_send_default_pii() setting, leading to potential PII leakage in URL data.
_{Severity: HIGH}

Suggested Fix

Add the if should_send_default_pii(): check around the lines that set url, HTTP_QUERY, and HTTP_FRAGMENT data in the non-streamed path (lines 131-137), mirroring the implementation in the streamed path.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: sentry_sdk/integrations/pyreqwest.py#L99

Potential issue: The pyreqwest integration has two code paths for creating spans: a
streamed path and a non-streamed path. The pull request adds a check for
`should_send_default_pii()` to prevent leaking URL data in the streamed path. However,
the same check is missing from the non-streamed path (lines 131-137). As a result, when
`send_default_pii` is set to `False`, the non-streamed path will still send `url`,
`HTTP_QUERY`, and `HTTP_FRAGMENT` data, which may contain personally identifiable
information (PII), contrary to the user's configuration.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[github-actions]

Codecov Results 📊

✅ 89953 passed | ⏭️ 6240 skipped | Total: 96193 | Pass Rate: 93.51% | Execution Time: 316m 9s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📈 +48
Passed Tests	📈 +48
Failed Tests	—
Skipped Tests	—

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2395 uncovered lines.
✅ Project coverage is 89.93%. Comparing base (base) to head (head).

Coverage diff

@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.93%    89.93%        —%
==========================================
  Files          192       192         —
  Lines        23784     23785        +1
  Branches      8210      8210         —
==========================================
+ Hits         21389     21390        +1
- Misses        2395      2395         —
- Partials      1342      1342         —

---

Generated by Codecov Action