Skip to content

ref(mcp): Inline _set_span_output_data() - #6762

Merged
alexander-alderman-webb merged 25 commits into
masterfrom
webb/mcp/use-middleware-3
Jul 28, 2026
Merged

ref(mcp): Inline _set_span_output_data()#6762
alexander-alderman-webb merged 25 commits into
masterfrom
webb/mcp/use-middleware-3

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unnecessary indirection by inlining _set_span_output_data().

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title ref(mcp): Inline _set_span_output_data() Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98741 passed | ⏭️ 6806 skipped | Total: 105547 | Pass Rate: 93.55% | Execution Time: 361m 20s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 78.57%. Project has 2562 uncovered lines.
✅ Project coverage is 89.55%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/mcp.py 78.57% ⚠️ 12 Missing and 12 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.54%    89.55%    +0.01%
==========================================
  Files          193       193         —
  Lines        24514     24514         —
  Branches      8674      8674         —
==========================================
+ Hits         21949     21952        +3
- Misses        2565      2562        -3
- Partials      1398      1402        +4

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 7, 2026 11:24
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 7, 2026 11:24
Base automatically changed from webb/mcp/use-middleware-2 to master July 28, 2026 07:52
@alexander-alderman-webb
alexander-alderman-webb merged commit 41cca06 into master Jul 28, 2026
140 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mcp/use-middleware-3 branch July 28, 2026 08:06
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Remove unnecessary indirection by inlining `_set_span_output_data()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants