Skip to content

fix(mcp): Stop adding the prompt name to arguments - #6765

Merged
alexander-alderman-webb merged 34 commits into
masterfrom
webb/mcp/prompt-arguments
Jul 28, 2026
Merged

fix(mcp): Stop adding the prompt name to arguments#6765
alexander-alderman-webb merged 34 commits into
masterfrom
webb/mcp/prompt-arguments

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

The prompt name is already recorded under the mcp.prompt.name attribute.

Issues

Reminders

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98741 passed | ⏭️ 6806 skipped | Total: 105547 | Pass Rate: 93.55% | Execution Time: 358m 49s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +11
Passed Tests 📈 +14
Failed Tests 📉 -3
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_circular_references_span_streaming
    • File: tests.tracing.test_misc

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2559 uncovered lines.
✅ Project coverage is 89.56%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.55%    89.56%    +0.01%
==========================================
  Files          193       193         —
  Lines        24520     24518        -2
  Branches      8676      8676         —
==========================================
+ Hits         21958     21959        +1
- Misses        2562      2559        -3
- Partials      1402      1400        -2

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 7, 2026 11:28
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 7, 2026 11:28
Comment thread sentry_sdk/integrations/mcp.py
Base automatically changed from webb/mcp/use-middleware-4 to master July 28, 2026 09:50
Comment thread sentry_sdk/integrations/mcp.py
Comment thread tests/integrations/mcp/test_mcp.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 492dd4a. Configure here.

Comment thread sentry_sdk/integrations/mcp.py
@alexander-alderman-webb
alexander-alderman-webb merged commit d82ddd1 into master Jul 28, 2026
271 of 273 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mcp/prompt-arguments branch July 28, 2026 11:52
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
The prompt name is already recorded as the `mcp.prompt.name` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants