fix(tracing): Skip child span creation in streaming path when no current span (web frameworks) - #6810
Merged
Conversation
…ent span (web frameworks) When span streaming is enabled and there is no current span, web framework integrations should not create new root segments for child-span operations. This adds a guard check using `sentry_sdk.traces.get_current_span()` before creating spans in the streaming path. Affected integrations: starlette, starlite, litestar, graphene, strawberry, aiohttp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry-warden[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
…uards The outgoing http.client span from the test fixture is now suppressed when there is no active span, reducing span counts in tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ericapisani
marked this pull request as ready for review
July 14, 2026 19:43
Contributor
Codecov Results 📊✅ 91785 passed | ⏭️ 6302 skipped | Total: 98087 | Pass Rate: 93.58% | Execution Time: 314m 44s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 62.16%. Project has 2456 uncovered lines. Files with missing lines (5)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.79% 89.75% -0.04%
==========================================
Files 193 193 —
Lines 23929 23957 +28
Branches 8286 8310 +24
==========================================
+ Hits 21485 21501 +16
- Misses 2444 2456 +12
- Partials 1361 1370 +9Generated by Codecov Action |
ericapisani
approved these changes
Jul 14, 2026
…en there is no current streamed span.
…om:getsentry/sentry-python into ivana/streaming-child-spans-web-frameworks
ericapisani
added a commit
that referenced
this pull request
Jul 15, 2026
The streaming path no longer emits a client span when there is no current span (#6810), so unpack only the server span.
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…ent span (web frameworks) (getsentry#6810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry_sdk.traces.get_current_span() is Noneguard before creating spans in the streaming pathTest plan
🤖 Generated with Claude Code