feat(streaming): Make set_conversation_id API work - #6866
Merged
Conversation
Contributor
Codecov Results 📊✅ 95450 passed | ⏭️ 6340 skipped | Total: 101790 | Pass Rate: 93.77% | Execution Time: 336m 24s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2510 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.65% 89.68% +0.03%
==========================================
Files 193 193 —
Lines 24324 24331 +7
Branches 8572 8576 +4
==========================================
+ Hits 21807 21821 +14
- Misses 2517 2510 -7
- Partials 1395 1395 —Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
July 24, 2026 07:39
alexander-alderman-webb
approved these changes
Jul 24, 2026
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
### Description In streaming mode, the `set_conversation_id` API doesn't currently do anything. Change that. #### Issues <!-- * resolves: getsentry#1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In streaming mode, the
set_conversation_idAPI doesn't currently do anything. Change that.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)