Skip to content

add options param to listIssueComments to get pagination result#399

Open
bambooom wants to merge 1 commit into
github-tools:masterfrom
bambooom:master
Open

add options param to listIssueComments to get pagination result#399
bambooom wants to merge 1 commit into
github-tools:masterfrom
bambooom:master

Conversation

@bambooom

Copy link
Copy Markdown

as I found that _requestAllPages will be deprecated, so I just add options to _request method to solve the problem I met in #398. 😊

@metaodi

metaodi commented Jun 20, 2017

Copy link
Copy Markdown

To have an options parameter is great, this would make it possible to pass the since parameter, to only get a subset of all comments.

@j-rewerts j-rewerts mentioned this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants