Skip to content

Working with two-factor authentication#450

Open
ddimitrioglo wants to merge 1 commit into
github-tools:masterfrom
ddimitrioglo:patch-1
Open

Working with two-factor authentication#450
ddimitrioglo wants to merge 1 commit into
github-tools:masterfrom
ddimitrioglo:patch-1

Conversation

@ddimitrioglo

Copy link
Copy Markdown

As mentioned in github API:

In addition to the Basic Authentication credentials, you must send the user's authentication code (i.e., one-time password) in the X-GitHub-OTP header.

And we will be able to use it like this:

const github = new GitHub({
    username: 'ddimitrioglo',
    password: 'xxxxxxxxxxxx',
    otp: '888999' // <= One-Time-Password
});

let me = github.getUser();

me.listRepos((err, repos) => {
    console.log(repos);
});
As mentioned in github API:
```
In addition to the Basic Authentication credentials, you must send the user's authentication code (i.e., one-time password) in the X-GitHub-OTP header.
```
And we will be able to use it like this:

```
const github = new GitHub({
    username: 'ddimitrioglo',
    password: 'xxxxxxxxxxxx',
    otp: '888999' // <= One-Time-Password
});

let me = github.getUser();

me.listRepos((err, repos) => {
    console.log(repos);
});
```
@j-rewerts

Copy link
Copy Markdown
Member

@clayreimann @CodyGramlich any idea how we would run tests on this? Seems like it may not be doable? Does GitHub provide any service you're aware of that would make testing possible?

@clayreimann

clayreimann commented Apr 9, 2019

Copy link
Copy Markdown
Member

@j-rewerts I think to add tests for this we'd have to create a test user, set them up with OTP, and then commit the secret/salt/QR code/whatever so that we could use something like [this library][opt-lib] to generate the OTP during tests. (That library is not a specific recommendation, just doing a quick search to see if there is likely to be a library that will work)

Thinking a bit more, we might need to have the configuration specify a callback that returns a current OTP value.

@j-rewerts

Copy link
Copy Markdown
Member

It seems like it could be possible. I'll sit on this for a bit and try to get something workable together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants