Skip to content

Fixed: Cannot read property 'encode' of undefined during executing writeFile()#456

Open
makishvili wants to merge 1 commit into
github-tools:masterfrom
makishvili:master
Open

Fixed: Cannot read property 'encode' of undefined during executing writeFile()#456
makishvili wants to merge 1 commit into
github-tools:masterfrom
makishvili:master

Conversation

@makishvili

@makishvili makishvili commented Jun 16, 2017

Copy link
Copy Markdown

I am trying to execute writeFile without optional options-parameter.
repo.writeFile('master', 'file.txt', 'some text', some message');

But getting the error:

~project/node_modules/github-api/dist/components/Repository.js:912
         var shouldEncode = options.encode !== false;
                                   ^

TypeError: Cannot read property 'encode' of undefined
    at Repository.writeFile (~project/node_modules/github-api/dist/components/Repository.js:912:36)
    at Object.<anonymous> (~project/gist.js:13:6)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)

@j-rewerts j-rewerts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makishvili Could you add a test showing the situation you've described? I'd like to see a test pass that wouldn't have passed before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants