Skip to content

Add add label to an issue#461

Open
asmsuechan wants to merge 3 commits into
github-tools:masterfrom
asmsuechan:add-add-label-to-an-issue
Open

Add add label to an issue#461
asmsuechan wants to merge 3 commits into
github-tools:masterfrom
asmsuechan:add-add-label-to-an-issue

Conversation

@asmsuechan

Copy link
Copy Markdown

I could not find these methods so I created. If anyone has any information about them, please let me know.

@asmsuechan asmsuechan force-pushed the add-add-label-to-an-issue branch from 4fbc7bd to 81706ba Compare July 11, 2017 12:32

@mtscout6 mtscout6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for these.

@asmsuechan

Copy link
Copy Markdown
Author

Sure

@j-rewerts

Copy link
Copy Markdown
Member

@clayreimann This API is marked as preview by GitHub. What is the policy on using preview APIs?

@clayreimann

Copy link
Copy Markdown
Member

@j-rewerts it's unclear. I guess we could mark the API as provisional in this library and let clients assume the risks

@j-rewerts

Copy link
Copy Markdown
Member

Yeah that's a good idea. I'll take this code and write tests for them when I have a second. I've added an issue here for going through the code base and adding warnings like this.

@clayreimann

Copy link
Copy Markdown
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants