Skip to content

Add fetch-on-empty optional attribute#100

Merged
keithamus merged 5 commits into
github:mainfrom
loisolire:allow-empty-query-search
Mar 30, 2023
Merged

Add fetch-on-empty optional attribute#100
keithamus merged 5 commits into
github:mainfrom
loisolire:allow-empty-query-search

Conversation

@loisolire

@loisolire loisolire commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

This attribute, when set, allows the auto-complete-element to fetch results with empty query value.

@loisolire loisolire changed the title Add extra condition for fetching empty queries. Jan 18, 2023
@loisolire loisolire force-pushed the allow-empty-query-search branch from 275f6c1 to 78bc5c4 Compare January 18, 2023 10:53
@loisolire loisolire marked this pull request as ready for review January 18, 2023 10:54
@loisolire loisolire requested a review from a team as a code owner January 18, 2023 10:54
@primer-css

Copy link
Copy Markdown

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good addition 👍

@MaximeRnR

Copy link
Copy Markdown
Contributor

Do we have a idea for when it will be merged ^^ ?

Comment thread src/auto-complete-element.ts Outdated
loisolire and others added 4 commits February 10, 2023 11:25
This attribute, when set, allows the auto-complete-element to fetch results with empty query value.

Co-authored-by: Maxime Reynier <maxime.rnr@gmail.com>
@loisolire loisolire force-pushed the allow-empty-query-search branch from 79c9f3f to d9c7cc7 Compare February 10, 2023 10:25
@MaximeRnR

Copy link
Copy Markdown
Contributor

Hello, do we have any idea when this will be merged ? Thanks a lot for your time !

@keithamus

Copy link
Copy Markdown
Contributor

Apologies, this should have been handled by the first responder staff member in rotation on January.

@keithamus keithamus merged commit a058977 into github:main Mar 30, 2023
@keithamus

Copy link
Copy Markdown
Contributor

This has been released as v3.4.0. Thanks for your efforts @loisolire! Thanks for bumping this @MaximeRnR

@MaximeRnR

Copy link
Copy Markdown
Contributor

Thx for your quick answer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants