polyfill for Promise.withResolvers#67
Merged
Merged
Conversation
mattcosta7
commented
Oct 17, 2024
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| reject: (reason?: any) => void | ||
| } | ||
| out.promise = new Promise<T>((resolve, reject) => { |
Member
Author
There was a problem hiding this comment.
nit - I would new this here, but we call this in tests directly, so haven't done so
mattcosta7
commented
Oct 17, 2024
|
|
||
| export function apply(): void { | ||
| if (!('withResolvers' in Promise)) { | ||
| Object.assign(Promise, {withResolvers}) |
Member
Author
There was a problem hiding this comment.
using Object.assign to avoid type errors from defining withResolvers on Promise
dgreif
reviewed
Oct 17, 2024
dgreif
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a polyfill for
Promise.withResolverswhich is baseline 2024see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers
see: https://github.com/tc39/proposal-promise-with-resolvers/blob/main/polyfills.js