Send original event details in combobox-commit CustomEvent

[colinwm]

I want to get some additional information about the originating trigger of the commit event (whether the ctrlKey or metaKey are pressed) to determine whether links should be opened in a new tab or not. Seems that information is not preserved in the combobox-commit CustomEvent.

I plumbed it through via details, lmk if you think this is reasonable

[primer-css]

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

• 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
• ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
• ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

[koddsson]

Looks good to me!

[koddsson]

Nitpick; What do you think about taking in details as a argument so that we adhere more to the API of CustomEvent?

Suggested change

	function fireCommitEvent(target: Element, originalEvent?: MouseEvent): void {
	target.dispatchEvent(new CustomEvent('combobox-commit', {bubbles: true, detail: {originalEvent}}))
	function fireCommitEvent(target: Element, detail: Record<string, unknown> | undefined = undefined): void {
	target.dispatchEvent(new CustomEvent('combobox-commit', {bubbles: true, detail}))

(☝🏻 I wrote this suggestion in the GitHub comment box so it might be wrong)

[rezrah]

Nit. For simplicity and consistency with the other arguments in this file, I think this could just be event as there's no superseding assignment or event mutation inside the closure. When I see original*, I usually expect something to happen to it after but it's just being forwarded here.

[rezrah]

👍

[colinwm]

@koddsson @rezrah PTAL, I updated to use your detail suggestion