Refactor gateway entry normalization across Claude/Copilot/Gemini converters#42678
Draft
Copilot wants to merge 2 commits into
Draft
Refactor gateway entry normalization across Claude/Copilot/Gemini converters#42678Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
7 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor gateway config entry transformation to eliminate duplication
Jul 1, 2026
Contributor
🤖 PR Triage
Score breakdown: impact 20 + urgency 8 + quality 12 Draft PR centralizing gateway config normalization across Claude/Copilot/Gemini converters. Good code-quality improvement with tests. Review alongside similar cross-provider refactors once ready.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three gateway config converters in
actions/setup/jsindependently implemented the same clone/mutate/URL-rewrite flow, creating drift risk for future schema or URL handling changes. This PR centralizes that transformation path while keeping provider-specific behavior isolated.Shared normalization primitive
normalizeGatewayEntry(entry, urlPrefix, mutate?)inconvert_gateway_config_shared.cjs.stringURLs only)Provider adapters reduced to intent-only mutations
convert_gateway_config_claude.cjs: setstype = "http"via mutation callback.convert_gateway_config_copilot.cjs: ensures defaulttools = ["*"]when missing.convert_gateway_config_gemini.cjs: removestypefor transport auto-detection.Coverage updates for shared path
convert_gateway_config_adapters.test.cjswith a focused test fornormalizeGatewayEntry, including immutability and URL rewrite behavior.