Skip to content

Add E2E Playwright tests for MCP Apps#1959

Draft
mattdholloway wants to merge 41 commits into
mainfrom
ui-playwright-e2e
Draft

Add E2E Playwright tests for MCP Apps#1959
mattdholloway wants to merge 41 commits into
mainfrom
ui-playwright-e2e

Conversation

@mattdholloway

Copy link
Copy Markdown
Contributor

Summary

Why

Fixes #

What changed

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Prompts tested (tool changes only)

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
    • I have added the new tool aliases in deprecated_tool_aliases.go
  • I am not renaming tools as part of this PR

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)
Comment thread .github/workflows/ui-e2e.yml Fixed
mattdholloway and others added 5 commits February 4, 2026 15:48
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Removed branch restrictions for push and pull_request events.
Comment thread ui/playwright.config.ts

webServer: {
command: "npx vite --port 5173",
port: 5173,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add a comment explaining why reuseExistingServer: !process.env.CI is used.

Comment thread ui/src/hooks/useMcpApp.ts
import type { App, CallToolResult } from "@modelcontextprotocol/ext-apps";
import type { App } from "@modelcontextprotocol/ext-apps";
import type { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
import { useState, useCallback } from "react";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to include a comment explaining why the CallToolResult import was changed.

Base automatically changed from mcp-ui-apps-3 to main February 12, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants