fix: add authorAssociation to IssueFragment (GraphQL path)

[lanxevo3]

Summary

Adds the missing \�uthorAssociation\ field to the \IssueFragment\ GraphQL struct and populates it in \ragmentToMinimalIssue(), fixing the missing \�uthor_association\ field in \list_issues\ responses when using the GraphQL path.

Changes

• \pkg/github/issues.go: Added \Author.Association\ field to \IssueFragment\ struct (GraphQL)
• \pkg/github/minimal_types.go: Set \AuthorAssociation\ in \ragmentToMinimalIssue()\ from \ragment.Author.Association\

Note

The REST path (\convertToMinimalIssue()) already correctly sets \AuthorAssociation\ from \issue.GetAuthorAssociation(). The GraphQL path was missing this field.

Fixes #2250

[lanxevo3]

Hey @github/mcp-team — checking in on this PR. It's been open since March 26 and is mergeable. Adds �uthorAssociation field to IssueFragment to fix the GraphQL codegen path. Any blockers or feedback? Happy to iterate.

[SamMorrowDrums]

Hi, I will try to look and get this in soon. It does make sense to provide the data.

[SamMorrowDrums]

Thanks for tackling this @lanxevo3, and apologies for the slow response.

Unfortunately the change as written won't work at runtime — authorAssociation isn't a field on the Actor interface that author returns, it's a top-level field on the Issue node itself. I verified against the live GraphQL API:

$ gh api graphql -f query='{ repository(owner:"github", name:"github-mcp-server") { issues(first:1) { nodes { author { login association } } } } }'
{"errors":[{"message":"Field 'association' doesn't exist on type 'Actor'", ...}]}

vs. the correct shape:

$ gh api graphql -f query='{ repository(owner:"github", name:"github-mcp-server") { issues(first:1) { nodes { authorAssociation author { login } } } } }'
{"data":{"repository":{"issues":{"nodes":[{"authorAssociation":"MEMBER","author":{"login":"toby"}}]}}}}

The unit tests pass because they mock the GraphQL response shape rather than validating against the real schema, so this slipped through.

What needs to change

In pkg/github/issues.go, move the field out of the Author struct and onto IssueFragment itself:

type IssueFragment struct {
    Number            githubv4.Int
    Title             githubv4.String
    Body              githubv4.String
    State             githubv4.String
    DatabaseID        int64
    AuthorAssociation githubv4.String

    Author struct {
        Login githubv4.String
    }
    // ...
}

In pkg/github/minimal_types.go, read the new field directly:

AuthorAssociation: string(fragment.AuthorAssociation),

One more (optional) ask

Issue #2250 also calls out that MinimalPullRequest is missing author_association on the REST path — it'd be great to address that here too while you're at it, but happy to take it as a follow-up if you'd rather keep this PR focused.

Let me know if you'd like me to push the fix on top, otherwise feel free to update and I'll re-review. Thanks!

[advancedresearcharray]

Addressed the review feedback from @SamMorrowDrums — authorAssociation is a top-level field on the Issue node, not on Actor.

Changes

pkg/github/issues.go

• Added AuthorAssociation githubv4.String to IssueFragment (and LegacyIssueFragment for the flag-disabled path)
• Removed the incorrect Author.Association nested field from the original PR

pkg/github/minimal_types.go

• fragmentToMinimalIssue() and legacyFragmentToMinimalIssue() now set AuthorAssociation: string(fragment.AuthorAssociation)
• Also added author_association to MinimalPullRequest / convertToMinimalPullRequest() for the REST path (Missing author_association field in list_issues and pull request responses #2250)

pkg/github/issues_test.go

• Updated GraphQL query matchers to include authorAssociation
• Mock responses now use top-level authorAssociation (matching the live schema)
• Added assertions that the field is populated in responses

Ready branch

Rebased on current main (includes #2605): https://github.com/advancedresearcharray/github-mcp-server/tree/fix/author-association-issue-fragment-2265

Compare: main...advancedresearcharray:fix/author-association-issue-fragment-2265

go test ./pkg/github/ -count=1 passes.

@lanxevo3 — if you can cherry-pick or merge that branch onto main in your fork, this should be ready for re-review. @SamMorrowDrums — happy for you to push the fix on top here if that's easier (maintainer edits are enabled).

[advancedresearcharray]

Updated the fix branch per @SamMorrowDrums's review feedback — authorAssociation is now a top-level field on IssueFragment (not nested under Actor.author), with tests and MinimalPullRequest.author_association included.

Verification: go test ./pkg/github/ -count=1 passes on current main.

Delivery options (no write access to lanxevo3/github-mcp-server):

1. Ready branch: https://github.com/advancedresearcharray/github-mcp-server/tree/fix/author-association-issue-fragment-2265
2. PR to update author's fork: fix: address review feedback for #2265 (authorAssociation on Issue node) lanxevo3/github-mcp-server#1 — merging this updates the fix: add authorAssociation to IssueFragment (GraphQL path) #2265 head branch
3. Upstream PR with the fix: fix: add authorAssociation to IssueFragment (GraphQL path) #2620 — maintainers can merge this directly if preferred

@SamMorrowDrums — since maintainer edits are enabled on this PR, pushing the fix branch onto lanxevo3/main would also unblock re-review here. Happy to close #2265 in favor of #2620 if that's easier.

[advancedresearcharray]

Addressed @SamMorrowDrums's review feedback — authorAssociation is now a top-level field on IssueFragment (not nested under Actor.author), with tests and MinimalPullRequest.author_association included.

Changes (4 files)

pkg/github/issues.go

• Added AuthorAssociation githubv4.String to IssueFragment (and LegacyIssueFragment)
• Removed the incorrect Author.Association nested field

pkg/github/minimal_types.go

• fragmentToMinimalIssue() and legacyFragmentToMinimalIssue() now set AuthorAssociation: string(fragment.AuthorAssociation)
• Added author_association to MinimalPullRequest / convertToMinimalPullRequest() for the REST path (Missing author_association field in list_issues and pull request responses #2250)

pkg/github/issues_test.go

• Updated GraphQL query matchers to include authorAssociation
• Mock responses now use top-level authorAssociation (matching the live schema)
• Added assertions that the field is populated in responses

pkg/github/pullrequests_test.go

• Added author_association assertions for get/list pull request handlers

Verification

go test ./pkg/github/ -count=1 -run 'Test_ListIssues|Test_GetPullRequest|Test_ListPullRequests' passes.

Delivery

Ready branch rebased on this PR's head: https://github.com/advancedresearcharray/github-mcp-server/tree/fix/pr-2265-review-feedback

Mergeable PR to update this head branch: lanxevo3#2

@SamMorrowDrums — maintainer edits are enabled; pushing the fix branch onto lanxevo3/main would unblock re-review here. Alternatively, the same fix on current main is in #2620.

[perplexiphone-cmd]

Issue