Skip to content

Fix return Thread node ID in get_review_comments response#2515

Merged
SamMorrowDrums merged 2 commits into
github:mainfrom
juidesai:fix/review-thread-id
May 21, 2026
Merged

Fix return Thread node ID in get_review_comments response#2515
SamMorrowDrums merged 2 commits into
github:mainfrom
juidesai:fix/review-thread-id

Conversation

@juidesai

Copy link
Copy Markdown
Contributor

Problem

pull_request_read with method: get_review_comments never returns the thread
node ID (e.g. PRRT_kwDO...). The README documents using this ID with
resolve_thread, making that workflow completely broken.

Root Cause

convertToMinimalReviewThread() in pkg/github/minimal_types.go maps
reviewThreadNodeMinimalReviewThread, but MinimalReviewThread had no
ID field, so thread.ID was silently dropped.

Fix

Added ID string to MinimalReviewThread and populate it via
fmt.Sprintf("%v", thread.ID) in convertToMinimalReviewThread.

Result

get_review_comments now includes "id" on each thread object, enabling the
documented resolve_thread workflow end-to-end.

@juidesai juidesai requested a review from a team as a code owner May 21, 2026 04:43
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SamMorrowDrums SamMorrowDrums merged commit 805ad75 into github:main May 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants