Skip to content

fix: clarify pending review creation#2569

Open
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/pending-review-tool-copy
Open

fix: clarify pending review creation#2569
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/pending-review-tool-copy

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

  • make the pull_request_review_write title say that create opens a pending review
  • clarify that method: "create" without event does not submit the review
  • update the tool snapshot and README tool list

Fixes #2524.

To verify

  • UPDATE_TOOLSNAPS=true go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1
  • go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1
  • go test ./pkg/github -count=1
  • go test ./...
  • git diff --check
@he-yufeng he-yufeng requested a review from a team as a code owner May 29, 2026 09:02
@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch from 1f952ed to 5a97566 Compare May 29, 2026 11:05
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased the branch onto current origin/main and force-pushed 5a97566.

Validation after rebase:

  • go test ./...

@SamMorrowDrums SamMorrowDrums left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeted fix for #2524 — makes it clear that create without event produces a pending review, and refreshes the description to cover all five methods (including resolve_thread/unresolve_thread). README and toolsnap are updated consistently.

Minor nit: the user-facing Title annotation still doesn't mention thread resolve/unresolve, while the description does. Could broaden in a follow-up (e.g. "Manage pull request reviews and review threads"), not blocking. LGTM.

@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch from 133347f to cc3f9b9 Compare June 4, 2026 03:51
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this approved branch onto current origin/main and force-pushed cc3f9b9.

Validation after rebase:

  • go test ./...
  • git diff --check origin/main..HEAD

The PR diff remains limited to README.md, pkg/github/pullrequests.go, and the pull request review toolsnap.

@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch from cc3f9b9 to 1101a48 Compare June 4, 2026 20:37
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this approved branch onto latest github:main again and force-pushed 1101a48.

Validation after rebase:

go test ./... -count=1
# ok

git diff --check origin/main..HEAD
# passed
@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch from 1101a48 to 5cb469b Compare June 6, 2026 18:00
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this approved branch onto current origin/main and force-pushed 5cb469b.

Validation after rebase:

go test ./...
# ok

git diff --check origin/main..HEAD
# passed
@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch 2 times, most recently from a988a47 to 6ab4dad Compare June 16, 2026 08:57
@he-yufeng he-yufeng force-pushed the fix/pending-review-tool-copy branch from 6ab4dad to b2bf8bb Compare June 20, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants