Skip to content

fix: let get_me handle missing arguments#2591

Open
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/get-me-empty-args
Open

fix: let get_me handle missing arguments#2591
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/get-me-empty-args

Conversation

@he-yufeng

@he-yufeng he-yufeng commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #2587.

Summary

get_me is a zero-argument tool, but it was registered through the generic argument-decoding helper. That still makes the call sensitive to whether a client sends {} or omits arguments entirely.

This patch registers get_me with the no-argument handler path instead. The handler does not need parsed arguments, so it can serve both forms consistently:

  • arguments: {}
  • no arguments field

Validation

  • go test ./pkg/github -run Test_GetMe -count=1
  • go test ./pkg/github -count=1
  • go test ./... -count=1
  • gofmt -w pkg/github/context_tools.go pkg/github/context_tools_test.go
  • git diff --check origin/main..HEAD
@he-yufeng he-yufeng requested a review from a team as a code owner June 2, 2026 02:32
@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from 24cf9ff to 86ba852 Compare June 2, 2026 18:45
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Updated this branch onto current origin/main.

Validated locally:

go test ./pkg/github -run Test_GetMe
go test ./pkg/github
git diff --check
@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from 86ba852 to 0ba6ee1 Compare June 5, 2026 00:36
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch on the latest upstream origin/main and reran validation locally.

Validated:

go test ./pkg/github -run Test_GetMe
go test ./pkg/github
go test ./...
git diff --check origin/main..HEAD

All passed.

@he-yufeng

Copy link
Copy Markdown
Contributor Author

Re-ran validation on the current branch:\n\n- \go test ./pkg/github -run Test_GetMe -count=1\n- \go test ./pkg/github -count=1\n- \go test ./...\n- \git diff --check origin/main...HEAD\n\nAll passed locally on Windows.

@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from 0ba6ee1 to 65fca9b Compare June 6, 2026 18:52
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto the latest upstream main and force-pushed the cleaned head.

Validated locally:

  • go test ./pkg/github -run Test_GetMe -count=1
  • go test ./pkg/github -count=1
  • go test ./...
  • git diff --check origin/main..HEAD
@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from 65fca9b to b52eecc Compare June 10, 2026 13:54
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto current upstream main again; the PR remains a one-commit, two-file change.

Validation on Windows:

go test ./pkg/github -run Test_GetMe -count=1
go test ./pkg/github -count=1
go test ./...
git diff --check origin/main..HEAD

All passed.

@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from b52eecc to 5c68c75 Compare June 11, 2026 22:53
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased the approved branch onto current upstream main and resolved the conflict by keeping the newer attachStaticIFCLabel path while preserving the missing-arguments handling for get_me.

Validation on Windows:

  • go test ./pkg/github -run Test_GetMe -count=1
  • go test ./pkg/github -count=1
  • go test ./...
  • git diff --check origin/main..HEAD
@he-yufeng he-yufeng force-pushed the fix/get-me-empty-args branch from 5c68c75 to 0933584 Compare June 16, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants