Skip to content

fix: close issue_write state updates with REST#2637

Open
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/issue-update-close-response
Open

fix: close issue_write state updates with REST#2637
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/issue-update-close-response

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

  • send normal issue_write close updates through the REST PATCH request when the close reason is not duplicate
  • keep the GraphQL close path for duplicate closes, where GitHub also needs the duplicate issue id
  • add a regression test for closing an issue with labels and state_reason: completed in one call

Fixes #2636.

To verify

  • go test ./pkg/github -run Test_UpdateIssue -count=1
  • go test ./pkg/github -count=1
  • go test ./...
  • git diff --check
@he-yufeng he-yufeng requested a review from a team as a code owner June 7, 2026 14:37
@he-yufeng he-yufeng force-pushed the fix/issue-update-close-response branch from a4e3a0e to 03febb4 Compare June 12, 2026 01:33
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto current main and reran the repository test suite.

Validation:

go test ./...
git diff --check origin/main..HEAD

Current head: 03febb4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants