Support type intent (rationale/confidence/suggestion) in issue write …#2663
Open
iulia-b wants to merge 1 commit into
Open
Support type intent (rationale/confidence/suggestion) in issue write …#2663iulia-b wants to merge 1 commit into
iulia-b wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the issue_write MCP tool to accept an issue type either as a plain string or as an object that can carry “intent” metadata (rationale/confidence/is_suggestion), enabling type suggestions with optional reasoning when updating issues.
Changes:
- Added a shared
typeschema forissue_writethat supportsstringor an intent-carrying object, and wired update flows to send the object form on the wire when intent is present. - Generalized the “custom PATCH payload” path for issue updates to support intent overrides for both labels and type.
- Updated tests, toolsnaps, and generated docs; enhanced docs generation to render
oneOfunion types asstring|object.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the documented issue_write.type parameter type to string|object. |
| pkg/github/issues.go | Adds issue_write type union schema + plumbing to send type intent via custom update payload. |
| pkg/github/issues_test.go | Adds coverage for issue_write update behavior and validation errors for type intent. |
| pkg/github/issues_granular.go | Introduces parseValueParamWithIntent; refactors granular type update to reuse shared intent parsing/payload. |
| pkg/github/granular_tools_test.go | Aligns expected error text with shared intent validation (“rationale must be …”). |
| pkg/github/toolsnaps/update_issue_type.snap | Updates snapshot to reflect shared intent property descriptions. |
| pkg/github/toolsnaps/issue_write.snap | Updates snapshot for issue_write to show type as oneOf (string or intent object). |
| pkg/github/toolsnaps/issue_write_ff_remote_mcp_issue_fields.snap | Same issue_write snapshot update for the feature-flagged variant. |
| docs/insiders-features.md | Regenerates docs showing issue_write.type as string|object. |
| docs/feature-flags.md | Regenerates docs showing issue_write.type as string|object and updated update_issue_type intent descriptions. |
| cmd/github-mcp-server/generate_docs.go | Enhances doc generation to display oneOf unions as a|b in generated markdown. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 0
6 tasks
Comment on lines
270
to
288
| // Get the type and description | ||
| switch prop.Type { | ||
| case "array": | ||
| switch { | ||
| case prop.Type == "array": | ||
| if prop.Items != nil { | ||
| typeStr = prop.Items.Type + "[]" | ||
| } else { | ||
| typeStr = "array" | ||
| } | ||
| case prop.Type == "" && len(prop.OneOf) > 0: | ||
| var branchTypes []string | ||
| for _, branch := range prop.OneOf { | ||
| if branch.Type != "" && !slices.Contains(branchTypes, branch.Type) { | ||
| branchTypes = append(branchTypes, branch.Type) | ||
| } | ||
| } | ||
| typeStr = strings.Join(branchTypes, "|") | ||
| default: | ||
| typeStr = prop.Type | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the general
issue_writetool so the type can be sent either as a plain string or as an object with optional rationale (<=280 chars),is_suggestionandconfidence.Summary
Add intent value for types in the MCP when updating an issue
Why
Fixes https://github.com/github/plan-track-agentic-toolkit/issues/350
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs