Route github.localhost to split-host URLs for local dotcom dev#2672
Draft
owenniblock wants to merge 1 commit into
Draft
Route github.localhost to split-host URLs for local dotcom dev#2672owenniblock wants to merge 1 commit into
owenniblock wants to merge 1 commit into
Conversation
A local dotcom checkout serves its APIs from api.github.localhost, uploads.github.localhost and raw.github.localhost — the same split-host shape as production. github.localhost didn't match the github.com or *.ghe.com branches in parseAPIHost though, so it fell through to newGHESHost, which then tried /api/v3 and /api/graphql against the apex and got 404/422. Add a github.localhost branch that mirrors the dotcom layout so the MCP server can talk to a local dotcom stack without anyone patching parseAPIHost by hand. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
"github": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a fourth branch to
parseAPIHostinpkg/utils/api.gofor hostnames matchinggithub.localhost(or any subdomain of it). It mirrors the dotcom split-host layout — REST atapi.github.localhost, GraphQL atapi.github.localhost/graphql, uploads/raw on their own subdomains, oauth at the apex.Why
A local dotcom checkout serves its APIs from the same split-host shape as production. But
github.localhostdoesn't match thegithub.comor*.ghe.combranches inparseAPIHost, so today it falls through tonewGHESHost, which tries/api/v3and/api/graphqlagainst the apex and gets 404/422 back.Hit this while testing the multi_select issue field PR (#2659) against local dotcom — without this patch the MCP server can't talk to the local stack at all without modifying
parseAPIHostby hand.Notes
notgithub.localhoststill routes through GHES).github.localhost— not barelocalhost:portstyle dev setups. Happy to broaden if anyone is using something different.