Skip to content

add markup options#1249

Merged
kivikakk merged 2 commits into
github:masterfrom
jinhucheung:perf-render-params
Jan 6, 2019
Merged

add markup options#1249
kivikakk merged 2 commits into
github:masterfrom
jinhucheung:perf-render-params

Conversation

@jinhucheung

Copy link
Copy Markdown
Contributor

add options to Gitlab::Markup::render_s

@kivikakk

kivikakk commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

Excellent; thank you!

@kivikakk kivikakk merged commit 8f436ff into github:master Jan 6, 2019
Comment thread test/markup_test.rb
@@ -92,7 +92,7 @@ def test_each_render_has_a_name
assert_equal "pod", GitHub::Markup.renderer('README.pod', '=head1').name
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • _@
Suggested change
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name
assert_equal "pod6", GitHub::Markup.renderer('README.pod6', '=begin pod').name

_

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants