Skip to content

chore(lint): code quality - #64

Merged
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:chore/code-quality
Nov 13, 2025
Merged

chore(lint): code quality#64
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:chore/code-quality

Conversation

@fredbi

@fredbi fredbi commented Nov 12, 2025

Copy link
Copy Markdown
Member

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.
@codecov

codecov Bot commented Nov 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.39130% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.81%. Comparing base (e00aa64) to head (562b254).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pointer.go 67.39% 9 Missing and 6 partials ⚠️

❌ Your patch status has failed because the patch coverage (67.39%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   72.04%   74.81%   +2.77%     
==========================================
  Files           2        2              
  Lines         279      274       -5     
==========================================
+ Hits          201      205       +4     
+ Misses         53       47       -6     
+ Partials       25       22       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi
fredbi force-pushed the chore/code-quality branch from ac0c679 to 614b909 Compare November 12, 2025 19:23
…sues

* extended the set of enabled linters

* improved readability of the set() method, which was too complex
* added systematic checks on type assertion
* removed impossible cases (type assertion _then_ same using reflect)

* test: removed the use of global variables
* test: improved the readability of tests
  * using t.Run() to label and hierarchize tests
  * using JSON test document as embedded asset

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fredbi force-pushed the chore/code-quality branch from 614b909 to 562b254 Compare November 13, 2025 22:28
@fredbi
fredbi merged commit 061f7b4 into go-openapi:master Nov 13, 2025
17 of 18 checks passed
@fredbi
fredbi deleted the chore/code-quality branch November 13, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant