Skip to content

Fix/code quality issues - #143

Merged
fredbi merged 7 commits into
go-openapi:masterfrom
fredbi:fix/code-quality-issue
Aug 13, 2026
Merged

Fix/code quality issues#143
fredbi merged 7 commits into
go-openapi:masterfrom
fredbi:fix/code-quality-issue

Conversation

@fredbi

@fredbi fredbi commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.
fredbi added 7 commits August 13, 2026 16:15
@fredbi
fix(number): fix issue in InDeltaSlice when comparing slices of diffe…
9a93c63 
…rent lengths

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
doc: updated agent skills with front-matter
560a9c6 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
refact(codegen): simplified test value expression parsing
f412a4f 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fix(codegen): internal defensive guard against uncontrolled recursion
3866804 
The limit is 10 levels (which is just theoretical and never happens).

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fix(equal): ExportedValues - add guard against infinite recursion
3450544 
The limit is 1000 levels of nesting on user-provided input.

The error surfaces to the caller, which is informed of an issue while
introspecting the provided value.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fix(assertions): Empty - add guard to limit recursion when following …
d995da6 
…a chain of pointers

The limit is 1000 levels. The error does not surface: a structure with a
chain of more than 1000 nested pointers is simply assumed "not empty".

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
doc: reformulated a few internal comments for clarity
033433b 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (875f467) to head (033433b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/assertions/equal.go 54.16% 11 Missing and 11 partials ⚠️
codegen/internal/generator/domains/domains.go 60.00% 1 Missing and 1 partial ⚠️
...en/internal/scanner/comments-parser/expressions.go 71.42% 1 Missing and 1 partial ⚠️
internal/assertions/equal_unary.go 60.00% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   91.60%   91.45%   -0.15%     
==========================================
  Files         103      103              
  Lines       12834    12856      +22     
==========================================
+ Hits        11756    11757       +1     
- Misses        842      850       +8     
- Partials      236      249      +13

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
@fredbi
fredbi merged commit df17975 into go-openapi:master Aug 13, 2026
23 of 24 checks passed
@fredbi
fredbi deleted the fix/code-quality-issue branch August 13, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@fredbi