Skip to content

Cleanup Go Module, remove spurious coverage file - #124

Merged
sbinet merged 3 commits into
go-python:masterfrom
sbinet-gonum:cleanup
Nov 7, 2019
Merged

Cleanup Go Module, remove spurious coverage file#124
sbinet merged 3 commits into
go-python:masterfrom
sbinet-gonum:cleanup

Conversation

@sbinet

@sbinet sbinet commented Nov 5, 2019

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files          60       60           
  Lines       11970    11970           
=======================================
  Hits         8707     8707           
  Misses       2729     2729           
  Partials      534      534
Impacted Files Coverage Δ
py/string.go 87.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f189...651b46c. Read the comment docs.

@sbinet
sbinet requested review from corona10 and ncw November 6, 2019 10:37
Comment thread go.mod

@corona10 corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbinet
sbinet merged commit b0a0efb into go-python:master Nov 7, 2019
@sbinet
sbinet deleted the cleanup branch November 7, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants