Skip to content

Adding strip, rstrip and lstrip methods to string class - #214

Merged
sbinet merged 1 commit into
go-python:mainfrom
bmeg:feature/string-strip
Jan 11, 2023
Merged

Adding strip, rstrip and lstrip methods to string class#214
sbinet merged 1 commit into
go-python:mainfrom
bmeg:feature/string-strip

Conversation

@kellrott

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jan 11, 2023

Copy link
Copy Markdown

Codecov Report

Base: 74.34% // Head: 74.35% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1ae7af7) compared to base (7512ac2).
Patch coverage: 77.14% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   74.34%   74.35%           
=======================================
  Files          76       76           
  Lines       12582    12617   +35     
=======================================
+ Hits         9354     9381   +27     
- Misses       2559     2563    +4     
- Partials      669      673    +4     
Impacted Files Coverage Δ
py/string.go 88.92% <77.14%> (-1.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbinet sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet
sbinet merged commit c60d425 into go-python:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants