Skip to content

Updating dict intialization method - #217

Merged
sbinet merged 2 commits into
go-python:mainfrom
bmeg:feature/dict-init
Jan 18, 2023
Merged

Updating dict intialization method#217
sbinet merged 2 commits into
go-python:mainfrom
bmeg:feature/dict-init

Conversation

@kellrott

Copy link
Copy Markdown
Contributor

Allows for dict initialization using:

  • Keyword arguments: dict(a="1", b="2", c="3")
  • Lists of tuples: dict( zip( "a,b,c".split(","), "1,2,3".split(",") ) )
@codecov

codecov Bot commented Jan 17, 2023

Copy link
Copy Markdown

Codecov Report

Base: 74.38% // Head: 74.41% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (62fd86d) compared to base (5ef0384).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   74.38%   74.41%   +0.03%     
==========================================
  Files          76       76              
  Lines       12656    12673      +17     
==========================================
+ Hits         9414     9431      +17     
  Misses       2567     2567              
  Partials      675      675              
Impacted Files Coverage Δ
py/dict.go 82.01% <100.00%> (+2.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbinet sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.
I have some comments, see below.

Comment thread py/dict.go
Comment thread py/dict.go

@sbinet sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks again.

@sbinet
sbinet merged commit 337df2a into go-python:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants