test: add coverage for sh: vars with included Taskfiles#2731
Open
JonZeolla wants to merge 1 commit intogo-task:mainfrom
Open
test: add coverage for sh: vars with included Taskfiles#2731JonZeolla wants to merge 1 commit intogo-task:mainfrom
JonZeolla wants to merge 1 commit intogo-task:mainfrom
Conversation
Add TestShVarWithIncludes to ensure sh: dynamic variables are correctly resolved when a Taskfile also has includes. This guards against regressions like the one fixed in v3.49.1 (go-task#2720, go-task#2721). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestShVarWithIncludesto ensuresh:dynamic variables resolve correctly when a Taskfile also hasincludes:Context
PR #2721 fixed a regression where global
sh:variables resolved to empty strings when the Taskfile hadincludes:. That PR was superseded by the revert in #2723, but no test was added to prevent the issue from recurring. This PR adds that missing test coverage.Test plan
TestShVarWithIncludespasses on currentmain(post-revert)DYNAMIC_VAR=helloandDERIVED_VAR=hello world🤖 Generated with Claude Code