LSP: Fix type bind, mark as experimental, deprecate direct LSP access#105016
Merged
Conversation
c8cfb6d to
d9fec9f
Compare
1 task
d9fec9f to
6e7d3ff
Compare
Member
Author
|
Updated to also fix the timing of registering the singleton, thus fixing two old issues about it. |
Mickeon
reviewed
Apr 6, 2025
Mickeon
left a comment
Member
There was a problem hiding this comment.
If this is approved by others, the methods that are not deprecated should absolutely provide a meaningful description.
fc2cf9a to
fb36523
Compare
Member
Author
|
Seems like singletons must directly inherit |
Calinou
reviewed
Apr 9, 2025
Calinou
reviewed
Apr 9, 2025
Calinou
reviewed
Apr 9, 2025
| <method name="is_smart_resolve_enabled" qualifiers="const"> | ||
| <return type="bool" /> | ||
| <description> | ||
| Returns whether the language server is providing the smart resolve feature. The feature can be configured through the editor settings. |
Member
There was a problem hiding this comment.
Suggested change
| Returns whether the language server is providing the smart resolve feature. The feature can be configured through the editor settings. | |
| Returns [code]true[/code] if the language server is providing the smart resolve feature, [code]false[/code] otherwise. The feature can be configured using [member EditorSettings.network/language_server/enable_smart_resolve]. |
Member
Author
There was a problem hiding this comment.
The editor settings does not show up in the docs, so I'd rather not add a link which might be broken.
Calinou
reviewed
Apr 9, 2025
dalexeev
reviewed
Apr 10, 2025
41d6068 to
b0d9313
Compare
b0d9313 to
fb09379
Compare
d61c024 to
41f5c57
Compare
Member
Author
|
I removed the singleton binding from this PR: What does this PR do now:
The singleton binding is still broken. This should be tackled separately. |
Mickeon
reviewed
Jun 16, 2025
a77675a to
ad7ce7e
Compare
ad7ce7e to
b9a4f98
Compare
b9a4f98 to
0dfcfcf
Compare
09fc807 to
7a39e03
Compare
7a39e03 to
c416cba
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (not anymore) #52162Fixes (not anymore) #86132The LSP types were not added at the right time, so they were not picked up at some places e.g. by the doctools (internal documentation recognized them though).
This PR binds them at the correct time to get picked up by the doc tools. The classes are now marked as experimental, the amount of internals that is exposed makes implementation of new LSP features while keeping behavior of all those methods infeasible.
In addition this PR marks some methods as deprecated: