Add pointer warping on wayland#112287
Conversation
|
It seems the commit hash in I just copied the pointer warp xml file from the main branch, should i include the one from 1.45 if its different? |
Yea, as wayland-protocols is at that version. If the protocol is not available there feel free to make a PR updating it.
Nah, it's done in only two places now and it's something that we should generally not do, as pointed out by the big comment.
Not sure tbh. I'll be fair, in these cases I just keep them there, duplicated. You never know if the other half will be there by the time you'll need to read that comment again :P |
e95791a to
1d153b6
Compare
8850dc3 to
89faf8f
Compare
89faf8f to
9f8a4ef
Compare
|
I keep forgetting to add changed files before committing |
9f8a4ef to
1500375
Compare
|
This is not working at all on my end: Fedora Kinoite 42 / KDE Plasma 6.5.1 |
|
How did you test it? Heres a test project i made for this: |
YeldhamDev
left a comment
There was a problem hiding this comment.
Oh, I see. I had prefer_wayland enabled and forgot that it's an editor setting. It works now.
CC @bruvzg to check the code.
deralmas
left a comment
There was a problem hiding this comment.
I was going to try it on my machine but it looks like sway does not implement it yet. Code looks fine except for a small nitpick.
1500375 to
876d66e
Compare
876d66e to
2b66ec7
Compare
7c878ca to
0d8a12c
Compare
|
Did I rebase at the wrong moment? Why's the windows builds failing already.... |
|
Seems like the nuget website is down. |
0d8a12c to
5311f54
Compare
5311f54 to
3e6b705
Compare
3e6b705 to
26f56e1
Compare
deralmas
left a comment
There was a problem hiding this comment.
Works wonderfully on KDE Plasma 6.5.4!
Sway works identically as before (turns out it was way more broken than I tought!) so "compatibility" is preserved :)
|
(Sorry for the delay and thank you for your patience!) |
26f56e1 to
4dceee5
Compare
|
Oops sorry, I forgot to push this lil' change 😅 It's trivial, just three lines for the embedder. Hope you don't mind. I didn't want to stall this PR further. |
|
I assume thats to make it also work in the editors embedded game window.. I don't know how that works so thanks for doing that. Should I rebase it again? |
You're welcome!
No need to. Usually rebasing is only necessary when conflicts arise. |
|
Thanks! |
fixes #64296
Uses the new pointer warping protocol.