Add Replace to SceneTree context menu#112985
Conversation
|
The paste options are getting increasingly confusing by adding another option. Not sure if it should be part of this PR but I can imagine that the three paste options should become something like as follows:
|
|
I tested this new option. The "pasted" node keeps all properties from the replaced node, and pasting a scene makes it lose instancing. What makes this different from simply changing the type? |
273da92 to
203532f
Compare
Fixed
|
203532f to
68fc000
Compare
68fc000 to
979d01b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Rebase your branch. |
979d01b to
6264bee
Compare
It was, but it seems there is a connection issue, and it was not completed correctly. |
|
I notice that this PR can resolve godotengine/godot-proposals#4991 and godotengine/godot-proposals#12284 |
6264bee to
cd3e243
Compare
KoBeWi
left a comment
There was a problem hiding this comment.
The functionality is fine overall, but some of the details are disputable. Like, should the properties be preserved? Or at least the position? When replacing with a branch (i.e. node with children), should the children also be pasted? What if pasting multiple nodes? Currently it only uses the first one in the clipboard.
Though the only problematic part is how this new operation handles child nodes. It's actually bugged for non-scene children, but that's an already-existing bug: #116281 It would be nice to resolve it properly, to avoid manually adding/removing nodes.
cd3e243 to
57fb0c8
Compare
Now the position will remain the same
Well, the main use case of paste as a replacement is for the Packed Scenes; other than that, if the user wants the children, copy and paste can be used |
57fb0c8 to
f0ba73f
Compare
You mean when the number of selectend node is equal to the number of clipboard nodes? |
KoBeWi
left a comment
There was a problem hiding this comment.
Some minor details left, but seems mostly fine now.
f0ba73f to
5d9c855
Compare
5d9c855 to
f37446c
Compare
|
Thanks! |
closes godotengine/godot-proposals#13616
2025-11-20.17-26-57.mp4