Skip to content

Hide TreeItem edit popup on scroll.#112998

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
thearchcoder:fix/hide-popup-on-wheel
Jan 31, 2026
Merged

Hide TreeItem edit popup on scroll.#112998
akien-mga merged 1 commit into
godotengine:masterfrom
thearchcoder:fix/hide-popup-on-wheel

Conversation

@thearchcoder

@thearchcoder thearchcoder commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Before, you could scroll while editing an item on a Tree node.

Before:

before.mp4

After:

after.mp4
@thearchcoder thearchcoder requested a review from a team as a code owner November 20, 2025 21:01
@AThousandShips AThousandShips added this to the 4.6 milestone Nov 21, 2025
@thearchcoder

Copy link
Copy Markdown
Contributor Author

Found an issue with this implementation, If you edit then scroll while hovering over the scroll bar (not the tree) then the tree doesn't pickup the scroll event and thus the same issue as before occurs again. Will fix this in the next commit and will only stop editing if the scroll value actually changed.

@thearchcoder

thearchcoder commented Nov 22, 2025

Copy link
Copy Markdown
Contributor Author

Fixed both issues. Now it will capture the input whether or not anything is focused since it checks directly if the scroll value changed. And now if the scroll value didint change then it wont stop editing.

2025-11-22.17-18-03.mp4

@KoBeWi KoBeWi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the more expected behavior would be to move the popup with scroll, but this works too. It cancels the editing, but it's not something that can happen by accident (I think?), so it shouldn't cause problems.

Comment thread scene/gui/tree.cpp Outdated
@akien-mga akien-mga modified the milestones: 4.6, 4.7 Jan 24, 2026
@akien-mga akien-mga changed the title Hide Tree item edit popup on scroll. Jan 31, 2026
@akien-mga akien-mga changed the title Hide TreeIem edit popup on scroll. Jan 31, 2026
@akien-mga akien-mga force-pushed the fix/hide-popup-on-wheel branch from 202946d to cb78af7 Compare January 31, 2026 21:35
@akien-mga akien-mga merged commit a6efb02 into godotengine:master Jan 31, 2026
20 checks passed
@akien-mga

Copy link
Copy Markdown
Member

Thanks! And congrats for your first merged Godot contribution 🎉

rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
…p-on-wheel

Hide TreeItem edit popup on scroll.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants