Fix theme properties not being handled correctly by MultiNodeEdit#115151
Merged
Conversation
YeldhamDev
commented
Jan 19, 2026
YeldhamDev
commented
Member
- Fix default values not appearing (fixes Theme overrides properties display incorrect values when multi-selecting several Control nodes. #115057).
- Fix properties sometimes not appearing if some are overridden and others don't.
YeldhamDev
added
bug
topic:editor
cherrypick:4.6
YeldhamDev
commented
Jan 19, 2026
YeldhamDev
force-pushed
the
multi_node_theme_fix
branch
from
86fb8cc to
55ee0fb
Compare
YeldhamDev
force-pushed
the
multi_node_theme_fix
branch
from
55ee0fb to
0f640e1
Compare
KoBeWi
approved these changes
Apr 10, 2026
Comment on lines
+193
to
+211
| if (usage_data->info.name == F.name && | ||
| usage_data->info.type == F.type && | ||
| usage_data->info.class_name == F.class_name && | ||
| usage_data->info.hint == F.hint && | ||
| usage_data->info.hint_string == F.hint_string) { | ||
| if (usage_data->info.usage != F.usage) { | ||
| // Checkable properties (mostly theme items) need special treatment. | ||
| if (usage_data->info.usage & PROPERTY_USAGE_CHECKABLE && F.usage & PROPERTY_USAGE_CHECKABLE) { | ||
| if (usage_data->info.usage & PROPERTY_USAGE_CHECKED) { | ||
| F.usage |= PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_CHECKED; | ||
| } else { | ||
| F.usage &= ~(PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_CHECKED); | ||
| } | ||
|
|
||
| if (usage_data->info.usage != F.usage) { | ||
| continue; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Is there some way to de-duplicate this code?
Member
Author
There was a problem hiding this comment.
The question is where the centralized code would reside. Considering that it exists only in two places, we can kick this can forward for a while.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.