Reset drag unfold timer when mouse exits Tree#115295
Merged
Merged
Conversation
KoBeWi
approved these changes
Jan 23, 2026
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Reset drag unfold timer when mouse exits Tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #115271
Kind of a regression fix of #110904 , since it was introduced during the dev phase of 4.6
Using
_reset_drop_mode_over()onNOTIFICATION_MOUSE_EXIT, ifenable_drag_unfoldinganddrop_mode_over(user is dragging TreeItem) are true. Originally, the timer for unfolding would start, but not stop if mouse had exited the tree.drop_mode_overis notnullptr, even after the mouse leaves Tree, and this variable is used for conditional insteaddrop_mode_flags, because the latter already resets to 0 through other means, meanwhile I only founddrop_mode_overto reset inside_reset_drop_mode_over(), which originally is only called whendrop_mode_flags= 0 duringNOTIFICATION_DRAG_END.drop_mode_overis reassigned once mouse enters Tree again, and_reset_drop_mode_over()already checks if the timer is running.