GDScript: Push multiline at the correct time when parsing super#115302
Merged
Repiteo merged 1 commit intoJan 26, 2026
Conversation
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…error-messages GDScript: Push multiline at the correct time when parsing `super`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115238
The
push_multilineshould only be done if there is actually an opening parenthesis. But also, looking at some other parts of the Analyzer, it looks likepush_multiline(true)should be called before eating the opening parenthesis. So I used the pattern I saw in other places: Check first, thenpush_multiline, thenadvance.P.S. It's been a while since I last worked with the GDScript module, hopefully I'm not missing anything important.