Reduce compile time by removing geometry_3d.h include from rendering_server.h#115452
Conversation
efd6b78 to
8e05fd3
Compare
clayjohn
left a comment
There was a problem hiding this comment.
Makes sense to me. It looks like there are no class members or private functions or really any reason not to make Geometry3D a namespace.
The only thing that isn't clear to me on the face of the code is how this affects GDScript/GDExtension bindings/doc generation. Is there any reason to think that bindings may be impacted by this change?
Nope! |
clayjohn
left a comment
There was a problem hiding this comment.
Sounds great! Thanks for the quick response
…pile time. Change `Geometry3D` from class to namespace.
8e05fd3 to
c56c297
Compare
|
Thanks! |
…-no-geometry Reduce compile time by removing `geometry_3d.h` include from `rendering_server.h`
Geometry2DandGeometry3D#111602The change reduces compile time, especially if
geometry_3d.hordelauney_3d.hare edited.I needed to change
Geometry3Dfromclasstonamespaceto make it happen, otherwise it would be impossible to forward-declareGeometry3D::MeshData. There are no further changes to this file (most of the changelog is whitespace).This makes sense anyhow since
Geometry3Ddoes not need to be instantiated.