Print file path when failing to load dynamic library#116125
Merged
Merged
Conversation
bruvzg
reviewed
Feb 10, 2026
| @@ -1058,7 +1058,7 @@ Error OS_Unix::open_dynamic_library(const String &p_path, void *&p_library_handl | |||
| path = get_executable_path().get_base_dir().path_join("../lib").path_join(p_path.get_file()); | |||
| } | |||
|
|
|||
| ERR_FAIL_COND_V(!FileAccess::exists(path), ERR_FILE_NOT_FOUND); | |||
| ERR_FAIL_COND_V_MSG(!FileAccess::exists(path), ERR_FILE_NOT_FOUND, vformat("Can't open dynamic library, file not found: '%s'.", path)); | |||
Member
There was a problem hiding this comment.
Suggested change
| ERR_FAIL_COND_V_MSG(!FileAccess::exists(path), ERR_FILE_NOT_FOUND, vformat("Can't open dynamic library, file not found: '%s'.", path)); | |
| ERR_FAIL_COND_V_MSG(!FileAccess::exists(path), ERR_FILE_NOT_FOUND, vformat("Can't open dynamic library, file not found: '%s'.", p_path)); |
I would use original p_path here, path is taking multiple values, so using only the value from the last check (../lib/libname) might be misleading.
Contributor
Author
There was a problem hiding this comment.
I was considering that, and it might make more sense since that's the path in the .gdextension, but I went with path since that's the thing it actually looks for. I'll change it to p_path if you find that more logical
JohanAR
force-pushed
the
fix-dyn-lib-missing-log
branch
from
a7e4303 to
2acdfdb
Compare
bruvzg
approved these changes
Feb 10, 2026
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…g-log Print file path when failing to load dynamic library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the file path when failing to open a dynamic library. Previously it would only print the path of the .gdextension file on failure, making debugging harder