Fix Curve point properties usage flags#116331
Merged
Repiteo merged 1 commit intoFeb 18, 2026
Merged
Conversation
Contributor
|
thanks, curve edit is totally unusable without this rn |
KoBeWi
approved these changes
Feb 18, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116323.
Fixes #116442
Regression from #92282:
Curve/Curve2D/Curve3Dper point properties were incorrectly changed to use default usage flags (includingPROPERTY_USAGE_STORAGE). These should be editor-only, actual data is stored in a single_dataproperty per curve.Duplicated data in #116323 MRP:
Curve::_set_point_positiongotvalue/offsetvalues swapped. But in fact, before #92282 there was a bug in theCurve::_set, as when setting a point position it was setting the offset before the value for the same point index:godot/scene/resources/curve.cpp
Lines 585 to 588 in f346633
but setting the offset for a point at given index might result in changing the index of the given point (as points are sorted by offsets). Correct is either:
or: