LSP: Fix singleton registration#116369
Merged
Merged
Conversation
Repiteo
approved these changes
Feb 16, 2026
Repiteo
left a comment
Contributor
There was a problem hiding this comment.
Discussed in this rc thread, and I agree that singletons should not be constrained to Object alone (at least, not without it being explicitly documented as such).
HolonProduction
commented
Feb 16, 2026
Ivorforce
approved these changes
Feb 16, 2026
56fcaac to
be6f769
Compare
akien-mga
approved these changes
Feb 16, 2026
be6f769 to
47bc8f0
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52162
Fixes #86132
The singleton is now registered on
MODULE_INITIALIZATION_LEVEL_EDITORinstead of a late callback.To make this work I removed an old test case that limited singletons to only types that inherit directly from
Object. This should be fine based on my question on RC.