Change HashSet copy constructor from implicit to explicit.#116381
Merged
Conversation
9316626 to
c924934
Compare
aaronfranke
approved these changes
Feb 16, 2026
Contributor
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashMapandAHashMapfrom implicit to explicit #115093LocalVectorfrom implicit to explicit #115309Listcopy constructor from implicit to explicit. #115646This change makes it harder to accidentally copy
HashSetinstances. This decreases the chance of performance problems and regressions.Programmers will be forced to take a reference, move, otherwise avoid the copy, or explicitly make the copy:
This PR is mostly performance agnostic; that is, if a copy was happening beforehand, there will be a copy afterwards (just explicit instead of implicit). There are a few minor exceptions that I'm very sure are safe.